Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CS tests have a few minor bugs to clean up #115

Open
2 tasks done
thnkslprpt opened this issue Dec 3, 2024 · 0 comments · May be fixed by #116
Open
2 tasks done

CS tests have a few minor bugs to clean up #115

thnkslprpt opened this issue Dec 3, 2024 · 0 comments · May be fixed by #116

Comments

@thnkslprpt
Copy link
Contributor

Checklist

  • I reviewed the Contributing Guide.
  • I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug
There are a few duplicate asserts and out-of-order UT_Set* functions that are run after the test function has already been called.

Code snips

UtAssert_True(CS_AppData.HkPacket.Payload.CmdCounter == 1, "CS_AppData.HkPacket.Payload.CmdCounter == 1");
UtAssert_True(CS_AppData.HkPacket.Payload.CmdCounter == 1, "CS_AppData.HkPacket.Payload.CmdCounter == 1");

/* Execute the function being tested */
CS_RecomputeBaselineAppCmd(&CmdPacket);
UT_SetDeferredRetcode(UT_KEY(CS_GetAppResTblEntryByName), 1, true);
UT_SetHandlerFunction(UT_KEY(CS_GetAppResTblEntryByName), CS_APP_CMDS_TEST_CS_GetAppResTblEntryByNameHandler1,
NULL);

Expected behavior
Correct tests.

Reporter Info
Avi Weiss   @thnkslprpt

thnkslprpt added a commit to thnkslprpt/CS that referenced this issue Dec 3, 2024
@thnkslprpt thnkslprpt linked a pull request Dec 3, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant