Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #330, Clean up redundant comments and empty lines #331

Merged
merged 2 commits into from
Oct 11, 2022

Conversation

thnkslprpt
Copy link
Contributor

@thnkslprpt thnkslprpt commented Oct 5, 2022

Checklist

Describe the contribution
Fixes #330
Removes redundant comments (incl. /* end of function */, /* end if */, function name in function header comments).
There were also a few cases of unnecessary empty lines (e.g. on the last line before the closing brace of a function) and also missing empty lines (e.g. between functions) which were corrected. Some of these empty lines trigger the CI format checks.

Testing performed
None (only comments and empty lines were amended).

Expected behavior changes
No impact on behavior.
These updates will reduce clutter and inconsistency in the code, thereby improving readability.

Contributor Info
@thnkslprpt

@dzbaker
Copy link
Contributor

dzbaker commented Oct 6, 2022

@thnkslprpt CCB 6 October 2022: Approved pending merge conflict resolution.

@thnkslprpt
Copy link
Contributor Author

@thnkslprpt CCB 6 October 2022: Approved pending merge conflict resolution.

Cleared up now mate.

@dzbaker dzbaker merged commit 09a899f into nasa:main Oct 11, 2022
@thnkslprpt thnkslprpt deleted the fix-330-comment-cleanup branch October 11, 2022 20:28
@dmknutsen dmknutsen added this to the Draco milestone Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redundant comments (/* end of function */, /* end if */ etc.) and clean up empty lines.
3 participants