Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #315, Remove dynamic memory use in UTs #316

Merged
merged 2 commits into from
Aug 25, 2022

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Aug 18, 2022

Checklist (Please check before submitting)

Describe the contribution

Testing performed
CI

Expected behavior changes
Squash warnings... also more maintainable unit tests (much simpler)

System(s) tested on
CI

Additional context
None

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Aug 18, 2022
@skliper skliper added this to the Draco milestone Aug 18, 2022
@skliper
Copy link
Contributor Author

skliper commented Aug 25, 2022

@dzbaker - this should be ready to merge, just initialized the checksum structure to non-zero to confirm it gets zeroed.

@dzbaker dzbaker added CCB:Approved and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Aug 25, 2022
@dzbaker dzbaker merged commit 2776979 into nasa:main Aug 25, 2022
@skliper skliper deleted the fix315-ut_malloc branch September 19, 2022 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnecessary use of dynamic memory in unit tests
3 participants