Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #131, Reset file psn and use OS_mv for out-of-order RX MD processing #279

Merged
merged 1 commit into from
Jul 14, 2022

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Jul 13, 2022

Checklist (Please check before submitting)

Describe the contribution

Switches from OS_rename to OS_mv which supports "rename" across file systems (via copy/delete)
Resets file cached position (from the file open) so it gets recalculated correctly

Testing performed
CI (added unit test asserts)

Expected behavior changes
Should now handle an out-of-order MD, and a tmp dir being on a different filesystem than the final location

System(s) tested on
CI

Additional context
Note the functional/CTF test is the full verification of this capability

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Jul 13, 2022
@skliper skliper added this to the Draco milestone Jul 13, 2022
@skliper skliper requested a review from semaldona July 13, 2022 12:58
@skliper skliper force-pushed the fix131-out_of_order_md branch from 655f37e to 8855399 Compare July 13, 2022 15:21
@skliper
Copy link
Contributor Author

skliper commented Jul 13, 2022

Note 8855399 adds operational temporary file documentation (no code changes).

@dzbaker dzbaker added CCB:Approved and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Jul 13, 2022
@dzbaker dzbaker merged commit 45d9dc6 into nasa:main Jul 14, 2022
@skliper skliper deleted the fix131-out_of_order_md branch September 19, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Likely issues in processing of deferred/reordered "md" packets
3 participants