diff --git a/docs/configs.md b/docs/configs.md index 56e6d5411eb..916d4d719e1 100644 --- a/docs/configs.md +++ b/docs/configs.md @@ -258,7 +258,7 @@ Name | SQL Function(s) | Description | Default Value | Notes spark.rapids.sql.expression.Year|`year`|Returns the year from a date or timestamp|true|None| spark.rapids.sql.expression.AggregateExpression| |Aggregate expression|true|None| spark.rapids.sql.expression.Average|`avg`, `mean`|Average aggregate operator|true|None| -spark.rapids.sql.expression.CollectList|`collect_list`|Collect a list of elements, now only supported by windowing.|false|This is disabled by default because for now the GPU collects null values to a list, but Spark does not. This will be fixed in future releases.| +spark.rapids.sql.expression.CollectList|`collect_list`|Collect a list of elements, now only supported by windowing.|true|None| spark.rapids.sql.expression.Count|`count`|Count aggregate operator|true|None| spark.rapids.sql.expression.First|`first_value`, `first`|first aggregate operator|true|None| spark.rapids.sql.expression.Last|`last`, `last_value`|last aggregate operator|true|None| diff --git a/docs/supported_ops.md b/docs/supported_ops.md index c112c80a359..65f70def15d 100644 --- a/docs/supported_ops.md +++ b/docs/supported_ops.md @@ -16435,7 +16435,7 @@ Accelerator support is described below. CollectList `collect_list` Collect a list of elements, now only supported by windowing. -This is disabled by default because for now the GPU collects null values to a list, but Spark does not. This will be fixed in future releases. +None aggregation input NS diff --git a/integration_tests/src/main/python/window_function_test.py b/integration_tests/src/main/python/window_function_test.py index ca6e05954b8..74eb6d00e3c 100644 --- a/integration_tests/src/main/python/window_function_test.py +++ b/integration_tests/src/main/python/window_function_test.py @@ -261,5 +261,4 @@ def test_window_aggs_for_rows_collect_list(): collect_list(c_struct) over (partition by a order by b,c_int rows between CURRENT ROW and UNBOUNDED FOLLOWING) as collect_struct from window_collect_table - ''', - {'spark.rapids.sql.expression.CollectList': 'true'}) + ''') diff --git a/sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuOverrides.scala b/sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuOverrides.scala index 2ab8d78a853..e7449807fb8 100644 --- a/sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuOverrides.scala +++ b/sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuOverrides.scala @@ -2416,8 +2416,7 @@ object GpuOverrides { (c, conf, p, r) => new ExprMeta[CollectList](c, conf, p, r) { override def convertToGpu(): GpuExpression = GpuCollectList( childExprs.head.convertToGpu(), c.mutableAggBufferOffset, c.inputAggBufferOffset) - }).disabledByDefault("for now the GPU collects null values to a list, but Spark does not." + - " This will be fixed in future releases."), + }), expr[ScalarSubquery]( "Subquery that will return only one row and one column", ExprChecks.projectOnly(