Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[actions] Upload artifacts from build check to use in storybook publishing #1077

Open
2 tasks
akdetrick opened this issue Nov 6, 2023 · 2 comments
Open
2 tasks
Assignees
Labels
good for contributors Clear scope and goals; easy for contributors to pick up UI-Platform Owned by Platform Team

Comments

@akdetrick
Copy link
Collaborator

akdetrick commented Nov 6, 2023

The storybook publish on PR action is doing a full checkout, npm install, build, and publish.

We already do a PR check where we attempt to build the project, and we could also build storybook in that check.

Definition of done

Artifacts uploaded by build check:

  • storybook out dir
  • dist/

Artifacts used by storybook publish:

  • storybook out dir

Artifacts used by jest:

  • dist/
@akdetrick akdetrick added the Platform fixes ticket visibility in project planning label Nov 6, 2023
@akdetrick akdetrick self-assigned this Dec 7, 2023
@akdetrick akdetrick modified the milestones: 2023.12-1, 2023.12-2 Dec 7, 2023
@akdetrick akdetrick removed their assignment Dec 8, 2023
@akdetrick akdetrick removed this from the 2023.12-2 milestone Dec 8, 2023
@akdetrick
Copy link
Collaborator Author

@reshav-abraham I checked again and it looks like this would be useful after all. I updated the definition of done to list what artifacts we want to keep and which actions can use them

@reshav-abraham
Copy link
Contributor

We should have a reusable action that checks out the repo and caches the build and installation this seems to be the only way to de-deuplicate these steps see:
https://docs.github.com/en/actions/using-workflows/caching-dependencies-to-speed-up-workflows
and
.github/workflows/build-e2e-ios-app.yml in
https://github.com/narmi/banking

@akdetrick akdetrick added the UI-Platform Owned by Platform Team label Jan 16, 2024
@kpburkett kpburkett removed the Platform fixes ticket visibility in project planning label Jan 19, 2024
@wrbrand wrbrand added the good for contributors Clear scope and goals; easy for contributors to pick up label May 21, 2024
@edakrong edakrong added the IM-Weekly label Jan 10, 2025 — with Linear
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good for contributors Clear scope and goals; easy for contributors to pick up UI-Platform Owned by Platform Team
Projects
None yet
Development

No branches or pull requests

5 participants