From 9ce1f9858dd142ed7382f664696610b9c415ed2f Mon Sep 17 00:00:00 2001 From: Lucy Liu Date: Mon, 21 Aug 2023 14:00:50 +1000 Subject: [PATCH 1/5] update pr template --- .github/PULL_REQUEST_TEMPLATE.md | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 1667249d3..b4b3fe3cd 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,8 +1,6 @@ # Description - - ## Type of change @@ -16,6 +14,4 @@ ## Final checklist: -- [ ] My PR is the minimum possible work for the desired functionality -- [ ] I have commented my code, particularly in hard-to-understand areas -- [ ] I have added [alt text](https://webaim.org/techniques/alttext/) to new images included in this PR \ No newline at end of file +- I have added [alt text](https://webaim.org/techniques/alttext/) to new images included in this PR \ No newline at end of file From b8ef82a52e7e96e232a7fc70caac5ad021085140 Mon Sep 17 00:00:00 2001 From: Lucy Liu Date: Tue, 22 Aug 2023 12:15:13 +1000 Subject: [PATCH 2/5] review --- .github/PULL_REQUEST_TEMPLATE.md | 23 +++++++++++++++-------- 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index b4b3fe3cd..c3dbeb9d0 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,7 +1,15 @@ +# References and relevant issues + + # Description - - - + + + ## Type of change @@ -9,9 +17,8 @@ - [ ] Adds new content page(s) - [ ] Fixes or improves workflow, documentation build or deployment -# References - - - ## Final checklist: -- I have added [alt text](https://webaim.org/techniques/alttext/) to new images included in this PR \ No newline at end of file +- If images included: I have added [alt text](https://webaim.org/techniques/alttext/) +If workflow, documentation build or deployment change: +- My PR is the minimum possible work for the desired functionality +- I have commented my code, to let others know what it does From b0ebed6e446849cb825c961b60f9599e4020160b Mon Sep 17 00:00:00 2001 From: Lucy Liu Date: Wed, 23 Aug 2023 20:34:29 +1000 Subject: [PATCH 3/5] review --- .github/PULL_REQUEST_TEMPLATE.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index c3dbeb9d0..e71b1f719 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -4,9 +4,10 @@ If this PR addresses an existing issue on the repo, please link to that issue here as "Closes #(issue-number)". --> # Description - + From 05872cdfb95481accda80b7c12a76e12d6e5772c Mon Sep 17 00:00:00 2001 From: Lucy Liu Date: Wed, 23 Aug 2023 20:44:32 +1000 Subject: [PATCH 4/5] fix --- .github/PULL_REQUEST_TEMPLATE.md | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index e71b1f719..a89246d62 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -5,21 +5,16 @@ please link to that issue here as "Closes #(issue-number)". --> # Description +context, improve/fix workflow/documentation build/deployment or something else? + -## Type of change - -- [ ] Fixes or improves existing content -- [ ] Adds new content page(s) -- [ ] Fixes or improves workflow, documentation build or deployment - -## Final checklist: + From cafd684447f572bf48104e297f9a4e45a45a1260 Mon Sep 17 00:00:00 2001 From: Lucy Liu Date: Thu, 14 Sep 2023 17:34:54 +1000 Subject: [PATCH 5/5] review --- .github/PULL_REQUEST_TEMPLATE.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index a89246d62..f9e7e2936 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,7 +1,8 @@ # References and relevant issues +please link to that issue here as "Closes #(issue-number)". +If this PR adds docs for a napari PR please add a "Depends on " --> # Description