Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add info on how to cross-reference gallery examples #534

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

TimMonko
Copy link

@TimMonko TimMonko commented Dec 6, 2024

References and relevant issues

Cross referencing used in napari PR#7426 and was a source of confusion for me.

Description

This documentation adds how-to cross-reference gallery examples. Info is included for both myst and rst formats and attempts to clear up what I was confused about.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 6, 2024
@TimMonko
Copy link
Author

TimMonko commented Dec 6, 2024

How can I understand why CircleCI is failing? It builds locally for me without this issue, and build finished with problems, 1 warning. make: *** [Makefile:31: docs-build] Error 1 is not descriptive?

@psobolewskiPhD
Copy link
Member

It's tricky especially right now with all the qt_window spam.
So the hint is that there was a warning. We set up the build to fail on warnings, so we deal with them.
So you need to search for WARNING but after the examples conversions are finished, so the proper build phase.
In this case I suspect it's this:

/home/circleci/project/docs/docs/developers/contributing/documentation/index.md:585: WARNING: 'myst' cross-reference target not found: 'gallery/add_image.html'

https://app.circleci.com/pipelines/github/napari/docs/1012/workflows/9435b88d-7504-47ad-97f4-bf432d7e967e/jobs/1003?invite=true#step-106-128127_93

Copy link
Member

@psobolewskiPhD psobolewskiPhD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 😎

@psobolewskiPhD psobolewskiPhD added this to the 0.5.6 milestone Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants