Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update slicing/rendering docs #424

Merged
merged 16 commits into from
Jun 25, 2024
Merged

Conversation

andy-sweet
Copy link
Member

@andy-sweet andy-sweet commented Jun 7, 2024

References and relevant issues

Closes #237
Closes #400

Description

This updates the current rendering docs in napari to reflect a few things.

  1. Describe how slicing and rendering works at a very high level in napari.
  2. Remove explanations of async rendering implementations that are no longer available on main.
  3. Add explanations and links to NAPs/issues/PRs to implementations that replace (2).

This is still very much a work-in-progress, so isn't worth a review yet. But wanted to share out progress as I make it (slowly...).

Some of the old explanations include some nice context and background material. At the time of writing, I've deleted some of these, but I am looking for ways to integrate them back into these docs.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jun 7, 2024
@@ -1,6 +1,6 @@
(nap-4-async-slicing)=

# NAP-4: Asynchronous slicing
# NAP-4 Asynchronous slicing
Copy link
Member Author

@andy-sweet andy-sweet Jun 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This NAP currently is the only one with a colon, but is now joining the em-dash family :p

@psobolewskiPhD
Copy link
Member

@andy-sweet This is looking outstanding!
😍

@andy-sweet andy-sweet added this to the 0.5.0 milestone Jun 7, 2024
@andy-sweet andy-sweet added the enhancement New feature or request label Jun 7, 2024

```{code-cell} python
# To get the current dimension order as tuple of int
viewer.dims.order
```
And then, changed programatically as follows:
And then, changed programmatically as follows:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the changes in this file are unrelated typo/spelling fixes. I can move them to a different PR.

@andy-sweet
Copy link
Member Author

Some more progress here. I think one more push and this should be ready for review.

@andy-sweet andy-sweet marked this pull request as ready for review June 14, 2024 20:29
@andy-sweet
Copy link
Member Author

andy-sweet commented Jun 14, 2024

I'm marking this ready for review mostly because I've run out of steam...

I included links to docs, parts of the API, and even private implementation details (where I used permalinks to main as it exists now). I also linked to some issues. The goal was to explain some of the implementation details to help other developers and contributors.

@brisvag : I included a sub-section on thick slicing here, since it seemed like a good fit for the content. It's not super detailed, but gives a basic example of how to use it and what it means. Feel free to make suggestions there!

I think some parts of this are pretty good, but it gets pretty rough in some places. The Drawing section is especially terrible. If anyone feels like improving that, I would welcome contributions!

@andy-sweet
Copy link
Member Author

Also happy to discuss this in the next documentation working group.

@psobolewskiPhD psobolewskiPhD self-requested a review June 14, 2024 22:55
@andy-sweet andy-sweet changed the title [WIP] Update slicing/rendering docs Update slicing/rendering docs Jun 17, 2024
Copy link
Contributor

@DragaDoncila DragaDoncila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andy-sweet this is awesome, thanks for making all these updates 🙏 I've left some comments, but it's mostly nitpicks!

docs/guides/rendering.md Outdated Show resolved Hide resolved
docs/guides/rendering.md Outdated Show resolved Hide resolved
docs/guides/rendering.md Outdated Show resolved Hide resolved
docs/guides/rendering.md Show resolved Hide resolved
docs/guides/rendering.md Outdated Show resolved Hide resolved
docs/guides/rendering.md Outdated Show resolved Hide resolved
docs/guides/rendering.md Show resolved Hide resolved
docs/guides/rendering.md Outdated Show resolved Hide resolved
docs/guides/rendering.md Outdated Show resolved Hide resolved
docs/guides/rendering.md Outdated Show resolved Hide resolved
@andy-sweet
Copy link
Member Author

@DragaDoncila : thanks for the review and the grammar fixes! I think I address all your comments here, but let me know if there are still issues.

Copy link
Contributor

@DragaDoncila DragaDoncila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andy-sweet thanks for making those updates, this can go in afaic!

@andy-sweet
Copy link
Member Author

In that case, I'll merge this after 24 hours unless anyone objects or has other suggestions.

@andy-sweet andy-sweet merged commit 20b8eca into napari:main Jun 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add link to rendering explanation at top of Async rendering page Update async rendering documentation
4 participants