-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistent doc deploy and PR preview #305
Comments
The problem is I'm not sure CircleCI can take github actions as a step, so I don't know if we can use Talley's action there. I will try to investigate. |
If we can't take a github actions step, could we replicate it manually? |
There is no option to take action directly |
Related we build napari differently: Circle CI installs: Line 35 in 1c6155f
GitHub Actions:
From #283 (comment) |
🧰 Task
The workflow for previewing docs in PRs via CircleCI and deploying docs are slightly different. Github uses Talleys QT action whereas we install manually in CircleCI. See: #283 (comment) for details
I think it may be a good idea to make them consistent as we would assume that if the docs look fine in CircleCI, they would be fine when deployed (this happened in #283 and #285)
The text was updated successfully, but these errors were encountered: