Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent doc deploy and PR preview #305

Open
lucyleeow opened this issue Dec 18, 2023 · 4 comments
Open

Consistent doc deploy and PR preview #305

lucyleeow opened this issue Dec 18, 2023 · 4 comments
Labels

Comments

@lucyleeow
Copy link
Collaborator

🧰 Task

The workflow for previewing docs in PRs via CircleCI and deploying docs are slightly different. Github uses Talleys QT action whereas we install manually in CircleCI. See: #283 (comment) for details

I think it may be a good idea to make them consistent as we would assume that if the docs look fine in CircleCI, they would be fine when deployed (this happened in #283 and #285)

@lucyleeow lucyleeow added the task label Dec 18, 2023
@melissawm
Copy link
Member

The problem is I'm not sure CircleCI can take github actions as a step, so I don't know if we can use Talley's action there. I will try to investigate.

@lucyleeow
Copy link
Collaborator Author

If we can't take a github actions step, could we replicate it manually?

@Czaki
Copy link
Contributor

Czaki commented Dec 19, 2023

There is no option to take action directly

@lucyleeow
Copy link
Collaborator Author

Related we build napari differently:

Circle CI installs:

python -m pip install -e "napari/[pyside,dev]"

GitHub Actions:

python -m pip install "napari/[all]"

CircleCI build is using PySide and the GH-Actions build is using PyQt5 (from napari[all]).

From #283 (comment)

@melissawm melissawm moved this to Prioritized in Documentation Working Group Jul 8, 2024
@melissawm melissawm moved this from Prioritized to Backlog in Documentation Working Group Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

3 participants