Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix session migration and assign message history to correct sessions #939

Merged
merged 10 commits into from
Nov 9, 2022

Conversation

Blackoverflow
Copy link
Collaborator

@Blackoverflow Blackoverflow commented Oct 30, 2022

This one contains:

  • a migration for the missing sessions
  • a migration to correctly assign the message history to the new sessions (leaving the old sid in a new column sv1id)
  • a update of signal-golang/textsecure to version 1.19.0

Still to do:

  • cleanup
  • verification that this works like intended
  • reference new release of textsecure

@Blackoverflow Blackoverflow requested a review from nanu-c October 31, 2022 21:47
go.sum Outdated Show resolved Hide resolved
Copy link
Collaborator

@olof-nord olof-nord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it is work in progress, but if we are thinking of switching to a fork of textsecure lets clarify the reasons why and start to think of how to upstream our changes?

@nuehm-arno
Copy link
Collaborator

Will do a review tomorrow!

@nuehm-arno
Copy link
Collaborator

I tried to review, but the changes are a bit too much for my limited go knowledge - sorry.

@Blackoverflow Blackoverflow changed the title WIP: Fix session migration and assign message history to correct sessions Fix session migration and assign message history to correct sessions Nov 5, 2022
@nanu-c nanu-c merged commit 7c19ccf into main Nov 9, 2022
@nanu-c nanu-c deleted the fix_session_migartion branch January 15, 2023 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants