Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

socket transport: No need for a cool down for this transport. #1979

Closed
wants to merge 1 commit into from

Conversation

gdamore
Copy link
Contributor

@gdamore gdamore commented Dec 8, 2024

If an error occurs, the application gets to know about it. There cannot be external factors that cause us to spin for memory, since this is not accessible via the network.

fixes #

Note that the above format should be used in your git commit comments.
You agree that by submitting a PR, you have read and agreed to our
contributing guidelines.

If an error occurs, the application gets to know about it.  There
cannot be external factors that cause us to spin for memory, since
this is not accessible via the network.
Copy link

codecov bot commented Dec 8, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.78%. Comparing base (3ca7bcc) to head (465bd08).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/sp/transport/socket/sockfd.c 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1979      +/-   ##
==========================================
- Coverage   81.80%   81.78%   -0.02%     
==========================================
  Files          95       95              
  Lines       24063    24047      -16     
  Branches     3207     3206       -1     
==========================================
- Hits        19685    19668      -17     
- Misses       4306     4308       +2     
+ Partials       72       71       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdamore gdamore closed this Dec 8, 2024
@gdamore gdamore deleted the sockfd-no-cooldown branch December 8, 2024 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant