Why no default for BUILD_SHARED_LIBS?

[blozano-tt]

nng/cmake/NNGOptions.cmake

Line 21 in ec714f0

option(BUILD_SHARED_LIBS "Build shared library" ${BUILD_SHARED_LIBS})

According to this, CMake does not define a default.

It seems like this project should be setting this to FALSE or OFF.

https://cmake.org/cmake/help/latest/variable/BUILD_SHARED_LIBS.html

[gdamore]

I believe if BUILD_SHARED_LIBS is unset at this point, it will become OFF. So this isn't necessarily a problem.

I'm not sure what the best practice here is -- because in theory someone might have already set that variable if we are included as a sub project.

[blozano-tt]

I believe if BUILD_SHARED_LIBS is unset at this point, it will become OFF. So this isn't necessarily a problem.

I'm not sure what the best practice here is -- because in theory someone might have already set that variable if we are included as a sub project.

I think you should default it to off for clarity.

Since it’s a cache variable… it’s designed to be overridden by command line, or option passing (fetch content)… and cache variables are shadowed by normal variables if there is some add_subdirectory inclusion.

Maybe ask ChatGPT to confirm :-).

[blozano-tt]

The reason I filed the issue, is I came here to check what the default expectation is for this library…