Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expo support #26

Open
SindreSvendby opened this issue Dec 11, 2017 · 1 comment
Open

Expo support #26

SindreSvendby opened this issue Dec 11, 2017 · 1 comment

Comments

@SindreSvendby
Copy link
Contributor

SindreSvendby commented Dec 11, 2017

Expo is so popular, that I almost assume people will test it out with it, so here are the problems I found with expo for my two components:

Importing images

change from import on top to require inline
eg.

import Rectangle34Copy6 from 'sushi_images/Rectangle34Copy6.png'
<Image source={React34Copy6} style={styles.Rectangle34Copy6} />

to

<Image source={require('./sushi_images/Rectangle34Copy6.png')} style={styles.Rectangle34Copy6} />

Children of Image

A Image can not have a child.
e.g

<Image source={require('./sushi_images/Rectangle34Copy6.png')} style={styles.Rectangle34Copy6}>
            <Text style={styles.LeMeoSushiCopy2}>Le Meo Sushi</Text>
</Image>

to

<Image source={require('./sushi_images/Rectangle34Copy6.png')} style={styles.Rectangle34Copy6} />
<Text style={styles.LeMeoSushiCopy2}>Le Meo Sushi</Text>

This should be tested more.

I have created the issue so that;

  1. pepole can see an solution if they have the same problem as me
  2. gather more feedback on integration with expo
  3. When we have enough info to know the workarounds that works, add to documentation
  4. In the end create a solution that supports expo
@chrisachard
Copy link
Collaborator

@SindreSvendby Thanks. I don't use Expo very much, so I'll have to test each of them and try to figure out the best way to fix them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants