Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI validate blocks #920

Merged
merged 8 commits into from
Aug 29, 2018
Merged

CLI validate blocks #920

merged 8 commits into from
Aug 29, 2018

Conversation

SergiySW
Copy link
Contributor

No description provided.

@rkeene rkeene added this to the V16.0 milestone Aug 24, 2018
@rkeene
Copy link
Contributor

rkeene commented Aug 24, 2018

Does this support epoch blocks and the merged iterators ?

@rkeene rkeene self-requested a review August 29, 2018 14:08
else if (vm.count ("debug_validate_blocks"))
{
rai::inactive_node node (data_path);
rai::transaction transaction (node.node->store.environment, nullptr, false);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This constructor changed and Colin was smart enough to change it so that this is caught. The last two arguments are reversed with the "parent" argument being optional and defaulting to nullptr, so it should be (environment, false)

Copy link
Contributor

@rkeene rkeene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work !

@rkeene rkeene merged commit a7c0a42 into nanocurrency:master Aug 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants