Signature checking thread #1411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkeene
pushed a commit
that referenced
this pull request
Nov 29, 2018
* Adding signature_checker class to separate out bulk processing of signatures. * Moving signature_checker off of block_processor so it can be shared. * Decoupling signature_checker from node. * Fix .gitignore file so it doesn't ignore the core_test directory. * Add signature_checker tests. * Using signature checker class to check votes. * Formatting. * Removing unused function and friend declaration.
rkeene
added a commit
that referenced
this pull request
Dec 18, 2018
This reverts commit 39dcfda. This change will still go forward on master (V18+)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.