Dedicate a full r hash block to attacker unknown bytes #1368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That paper was for SHA-512, though its strategies are likely applicable to blake2b (and the block size is the same for both). |
clemahieu
reviewed
Nov 9, 2018
PlasmaPower
force-pushed
the
r-gen-full-block
branch
from
c99a597 to
70af14b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #1353. I noticed that https://eprint.iacr.org/2017/985.pdf recommended dedicating a full hash block to the key and random bytes to prevent side channel attacks (I don't recall that from the paper I had previously read). This is also similar to how keys work in blake2b, and again there's really no reason not to do it.