Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factor out logging #1262

Merged
merged 1 commit into from
Oct 5, 2018
Merged

Factor out logging #1262

merged 1 commit into from
Oct 5, 2018

Conversation

cryptocode
Copy link
Contributor

Part of #1112

This moves the logging class into a separate file. This change showed that boost::shared_ptr was imported indirectly from the boost logging includes. No need to keep this dependency - moved to std::shared_ptr.

@cryptocode cryptocode mentioned this pull request Oct 5, 2018
Open
16 tasks
@rkeene rkeene added the functionality quality improvements This item indicates the need for or supplies a better way to implement existing functionality label Oct 5, 2018
@rkeene rkeene added this to the V17.0 milestone Oct 5, 2018
rkeene
rkeene approved these changes Oct 5, 2018
View reviewed changes
Copy link
Contributor

@rkeene rkeene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably just moved all the contents without changing anything 😄

@rkeene rkeene merged commit ca254e5 into nanocurrency:master Oct 5, 2018
@cryptocode cryptocode deleted the nodesplit-logging branch October 5, 2018 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkeene rkeene rkeene approved these changes

Assignees

@cryptocode cryptocode

Labels
functionality quality improvements This item indicates the need for or supplies a better way to implement existing functionality
Projects
None yet
Milestone
V17.0
Development

Successfully merging this pull request may close these issues.
2 participants
@cryptocode @rkeene