Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Republish unconfirmed blocks with delay #1232

Merged
merged 3 commits into from
Sep 26, 2018

Conversation

SergiySW
Copy link
Contributor

100 ms by default
25 ms for RPC republish

100 ms by default
25 ms for RPC republish
Copy link
Contributor

@rkeene rkeene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me !

@rkeene rkeene added this to the V16.1 milestone Sep 25, 2018
@PlasmaPower
Copy link
Contributor

I'm a bit want of more of these gradual broadcast systems. If we confirm it helps, then LGTM though.

Copy link
Contributor

@argakiig argakiig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm as well, I like it

50 ms for live & beta networks
10 ms for test network
@rkeene
Copy link
Contributor

rkeene commented Sep 26, 2018

/workspace/rai/node/node.cpp: In member function 'void rai::active_transactions::announce_loop()':
/workspace/rai/node/node.cpp:4023:95: error: 'broadcast_interval_ms' was not declared in this scope
   condition.wait_for (lock, std::chrono::milliseconds (announce_interval_ms + roots.size () * broadcast_interval_ms));

@SergiySW
Copy link
Contributor Author

/workspace/rai/node/node.cpp: In member function 'void rai::active_transactions::announce_loop()':
/workspace/rai/node/node.cpp:4023:95: error: 'broadcast_interval_ms' was not declared in this scope
   condition.wait_for (lock, std::chrono::milliseconds (announce_interval_ms + roots.size () * broadcast_interval_ms));

Fixed

@rkeene rkeene merged commit 9701d6e into nanocurrency:master Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants