Require 2 conditions to confirm election #1157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both sum >= node.config.online_weight_minimum & have_quorum () required To prevent possible situations with confirmed election without calling block_processor.force or block_processor.force without confirmed election
|
Blocks need to be able to be forced out before quorum is reached otherwise consensus could deadlock. |
|
For forcing blocks |
rkeene
reviewed
Sep 21, 2018
Move tally-sum-to-online-stake comparison inside the `have_quorum()` function
rkeene
added
the
incomplete
rkeene
removed
the
incomplete
|
Ensure sum of all votes is greater than the online minimum before attempting to get confirmation on a block |
This was referenced Sep 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both sum >= node.config.online_weight_minimum & have_quorum () required
To prevent possible situations with confirmed election without calling block_processor.force or block_processor.force without confirmed election