-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release asset: official Docker image #754
Comments
As documented in the wiki, the official image is |
Wiki!? Wow 👓 I didn't find that, since it is merely linked as the final bullet point in a long list under "Links & Resources" of the README... So to answer the question: yes, I think it would be reasonable to see, under the "Looking to start a node?"-section on nano.org, the link "Grab the Linux build here:" be followed by "...or run in a Docker container" |
...and like the subject says: It would reinforce the officialness had the link to the |
Third but not least: https://hub.docker.com/u/nanocurrency/ looks completely anonymous and is from a Docker hub users perspective completely undocumented. I'm not sure I would've pulled from there... |
+1 the project would benefit if 'nanocurrency' user gains official status on Docker Hub. As with all best practices on Docker Hub there should be a link to the source repository, a link to the Dockerfile used to build the image and more comprehensive description of the project. I chose not to run that image until I read the instructions on the Milestone 11 annoucement which specifically references Given how easy it is to change a wiki I wouldn't use that as any source of validity. |
Some side note: I realised that the Docker Hub files are binary already, you can't really see what's in them. So the hidden |
It's as open source as any other binary, e.g. Firefox. In addition, if you try building the Dockerfile yourself, you should theoretically get the same product. |
Related issue #863 |
I have added a link to the wiki page in the Release V17.0 releases and we'll keep that link in the future release announcements. Since we are constantly working on this software and systems, we miss important bits of perspective on what it looks like from the outside. Thank you for helping us ! |
Description of bug:
I want to run the client inside of a docker container, keeping the blockchain, config and keys on separate volumes.
Steps to reproduce the issue:
Describe the results you received:
Neither of the searches https://hub.docker.com/search/?isAutomated=0&isOfficial=0&page=1&pullCount=0&q=nano&starCount=0 or https://hub.docker.com/search/?isAutomated=0&isOfficial=0&page=1&pullCount=0&q=raiblocks&starCount=0 return any conclusive results.
Describe the results you expected:
Additional information you deem important (e.g. issue happens only occasionally):
Until there is a clear, correctly named, automatically built official image, there is a good opportunity for someone to upload a hacked image to the hub in order to steal peoples funds etc.
Environment:
logs
(n/a)
The text was updated successfully, but these errors were encountered: