Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Websocket include_sideband_info not working with include_block #4452

Open
Benskalz opened this issue Mar 4, 2024 · 2 comments
Open

Websocket include_sideband_info not working with include_block #4452

Benskalz opened this issue Mar 4, 2024 · 2 comments

Comments

@Benskalz
Copy link

Benskalz commented Mar 4, 2024

Summary

include_sideband_info doesn't seem to work with "include_block":"true".

Node version

V26.1

Build details

Docker container

OS and version

Centos 9

Steps to reproduce the behavior

  1. When sending this to websocket:
{
  "action": "subscribe",
  "topic": "confirmation",
  "options": {
    "include_sideband_info": "true"
  }
}

or

{
  "action": "subscribe",
  "topic": "confirmation",
  "options": {
    "include_sideband_info": "true",
    "include_block": "true"
  }
}

Expected behavior

Sideband data is expected like this:

{
    "topic": "confirmation",
    "time": "1709526597927",
    "message": {
        "account": "...",
        "amount": "...",
        "hash": "...",
        "confirmation_type": "active_quorum",
         "sideband": {
            "height": "2",
            "local_timestamp": "1709474942"
        }
        "block": {
            ...
        }

    }
}

Actual behavior

sideband data is not included:

{
    "topic": "confirmation",
    "time": "1709526597927",
    "message": {
        "account": "...",
        "amount": "...",
        "hash": "...",
        "confirmation_type": "active_quorum",
        "block": {
            ...
        }
    }
}

Possible solution

No response

Supporting files

No response

@dsiganos
Copy link
Contributor

dsiganos commented Mar 5, 2024

Do you know if it was working in the previous version?

@Benskalz
Copy link
Author

Benskalz commented Mar 5, 2024

Do you know if it was working in the previous version?

I don't know, I've just started to use this option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants