Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove sudo from buildci.sh and re-test release process #4001

Open
dsiganos opened this issue Nov 16, 2022 · 0 comments
Open

Remove sudo from buildci.sh and re-test release process #4001

dsiganos opened this issue Nov 16, 2022 · 0 comments
Labels
exclude from changelog Indicates the change is not relevant for appearing in the release changelog quality improvements This item indicates the need for or supplies changes that improve maintainability
Milestone
V25.0

Comments

@dsiganos
Copy link
Contributor

The script ci/build-ci uses sudo to gain root access. We should not need to do that just to build our software.

TODO: remove the sudo and test that the release process is not broken

REF:

nano-node/ci/build-ci.sh

Line 67 in 754ee4a

sudo cmake --build ${PWD} --target all -- -j2

@dsiganos dsiganos added quality improvements This item indicates the need for or supplies changes that improve maintainability exclude from changelog Indicates the change is not relevant for appearing in the release changelog labels Nov 16, 2022
@dsiganos dsiganos added this to the V25.0 milestone Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
exclude from changelog Indicates the change is not relevant for appearing in the release changelog quality improvements This item indicates the need for or supplies changes that improve maintainability
Projects
None yet
Milestone
V25.0
Development

No branches or pull requests
1 participant
@dsiganos