Unit test ledger_walker.ladder_geometry fails sometimes

[dsiganos]

2021-09-22T18:38:37.1927640Z [ RUN      ] ledger_walker.ladder_geometry
2021-09-22T18:38:44.2354130Z /Users/runner/work/nano-node/nano-node/nano/core_test/ledger_walker.cpp:199: Failure
2021-09-22T18:38:44.2362870Z Expected equality of these values:
2021-09-22T18:38:44.2363450Z   *amounts_expected_backwards_itr++
2021-09-22T18:38:44.2363860Z     Which is: 1000
2021-09-22T18:38:44.2364920Z   block->balance ().number () - previous_balance.number ()
2021-09-22T18:38:44.2365420Z     Which is: 2
2021-09-22T18:38:44.2366470Z /Users/runner/work/nano-node/nano-node/nano/core_test/ledger_walker.cpp:199: Failure
2021-09-22T18:38:44.2367200Z Expected equality of these values:
2021-09-22T18:38:44.2367700Z   *amounts_expected_backwards_itr++
2021-09-22T18:38:44.2368090Z     Which is: 2
2021-09-22T18:38:44.2368980Z   block->balance ().number () - previous_balance.number ()
2021-09-22T18:38:44.2369460Z     Which is: 1000
2021-09-22T18:38:44.2370920Z /Users/runner/work/nano-node/nano-node/nano/core_test/ledger_walker.cpp:199: Failure
2021-09-22T18:38:44.2371590Z Expected equality of these values:
2021-09-22T18:38:44.2372090Z   *amounts_expected_backwards_itr++
2021-09-22T18:38:44.2372490Z     Which is: 1000
2021-09-22T18:38:44.2373340Z   block->balance ().number () - previous_balance.number ()
2021-09-22T18:38:44.2373830Z     Which is: 6
2021-09-22T18:38:44.2374770Z /Users/runner/work/nano-node/nano-node/nano/core_test/ledger_walker.cpp:199: Failure
2021-09-22T18:38:44.2375680Z Expected equality of these values:
2021-09-22T18:38:44.2376180Z   *amounts_expected_backwards_itr++
2021-09-22T18:38:44.2376580Z     Which is: 6
2021-09-22T18:38:44.2377470Z   block->balance ().number () - previous_balance.number ()
2021-09-22T18:38:44.2377950Z     Which is: 7
2021-09-22T18:38:44.2379060Z /Users/runner/work/nano-node/nano-node/nano/core_test/ledger_walker.cpp:203: Failure
2021-09-22T18:38:44.2379730Z Expected equality of these values:
2021-09-22T18:38:44.2380230Z   amounts_expected_backwards_itr
2021-09-22T18:38:44.2381160Z     Which is: 8-byte object <30-46 D3-09 A8-7F 00-00>
2021-09-22T18:38:44.2381680Z   amounts_expected_backwards.cend ()
2021-09-22T18:38:44.2382550Z     Which is: 8-byte object <40-46 D3-09 A8-7F 00-00>
2021-09-22T18:38:44.2461470Z /Users/runner/work/nano-node/nano-node/nano/core_test/ledger_walker.cpp:218: Failure
2021-09-22T18:38:44.2462210Z Expected equality of these values:
2021-09-22T18:38:44.2462680Z   *amounts_expected_itr++
2021-09-22T18:38:44.2463060Z     Which is: 1000
2021-09-22T18:38:44.2464350Z   block->balance ().number () - previous_balance.number ()
2021-09-22T18:38:44.2464890Z     Which is: 1
2021-09-22T18:38:44.2465970Z /Users/runner/work/nano-node/nano-node/nano/core_test/ledger_walker.cpp:218: Failure
2021-09-22T18:38:44.2466640Z Expected equality of these values:
2021-09-22T18:38:44.2467110Z   *amounts_expected_itr++
2021-09-22T18:38:44.2467470Z     Which is: 1
2021-09-22T18:38:44.2468380Z   block->balance ().number () - previous_balance.number ()
2021-09-22T18:38:44.2468880Z     Which is: 1000
2021-09-22T18:38:44.2469870Z /Users/runner/work/nano-node/nano-node/nano/core_test/ledger_walker.cpp:218: Failure
2021-09-22T18:38:44.2470550Z Expected equality of these values:
2021-09-22T18:38:44.2471000Z   *amounts_expected_itr++
2021-09-22T18:38:44.2471370Z     Which is: 1000
2021-09-22T18:38:44.2472230Z   block->balance ().number () - previous_balance.number ()
2021-09-22T18:38:44.2472710Z     Which is: 3
2021-09-22T18:38:44.2473670Z /Users/runner/work/nano-node/nano-node/nano/core_test/ledger_walker.cpp:218: Failure
2021-09-22T18:38:44.2474330Z Expected equality of these values:
2021-09-22T18:38:44.2474880Z   *amounts_expected_itr++
2021-09-22T18:38:44.2475240Z     Which is: 3
2021-09-22T18:38:44.2476100Z   block->balance ().number () - previous_balance.number ()
2021-09-22T18:38:44.2476600Z     Which is: 4
2021-09-22T18:38:44.2477530Z /Users/runner/work/nano-node/nano-node/nano/core_test/ledger_walker.cpp:218: Failure
2021-09-22T18:38:44.2478220Z Expected equality of these values:
2021-09-22T18:38:44.2478680Z   *amounts_expected_itr++
2021-09-22T18:38:44.2479230Z     Which is: 4
2021-09-22T18:38:44.2480130Z   block->balance ().number () - previous_balance.number ()
2021-09-22T18:38:44.2480600Z     Which is: 5
2021-09-22T18:38:44.2481550Z /Users/runner/work/nano-node/nano-node/nano/core_test/ledger_walker.cpp:218: Failure
2021-09-22T18:38:44.2482220Z Expected equality of these values:
2021-09-22T18:38:44.2482680Z   *amounts_expected_itr++
2021-09-22T18:38:44.2483180Z     Which is: 5
2021-09-22T18:38:44.2484070Z   block->balance ().number () - previous_balance.number ()
2021-09-22T18:38:44.2484560Z     Which is: 8
2021-09-22T18:38:44.2485510Z /Users/runner/work/nano-node/nano-node/nano/core_test/ledger_walker.cpp:218: Failure
2021-09-22T18:38:44.2486180Z Expected equality of these values:
2021-09-22T18:38:44.2486630Z   *amounts_expected_itr++
2021-09-22T18:38:44.2486990Z     Which is: 8
2021-09-22T18:38:44.2487820Z   block->balance ().number () - previous_balance.number ()
2021-09-22T18:38:44.2488600Z     Which is: 9
2021-09-22T18:38:44.2489580Z /Users/runner/work/nano-node/nano-node/nano/core_test/ledger_walker.cpp:218: Failure
2021-09-22T18:38:44.2490260Z Expected equality of these values:
2021-09-22T18:38:44.2490710Z   *amounts_expected_itr++
2021-09-22T18:38:44.2491060Z     Which is: 9
2021-09-22T18:38:44.2491910Z   block->balance ().number () - previous_balance.number ()
2021-09-22T18:38:44.2492390Z     Which is: 10
2021-09-22T18:38:44.2493350Z /Users/runner/work/nano-node/nano-node/nano/core_test/ledger_walker.cpp:222: Failure
2021-09-22T18:38:44.2494020Z Expected equality of these values:
2021-09-22T18:38:44.2494470Z   amounts_expected_itr
2021-09-22T18:38:44.2495340Z     Which is: 16-byte object <40-46 D3-09 A8-7F 00-00 80-45 D3-09 A8-7F 00-00>
2021-09-22T18:38:44.2495890Z   amounts_expected_backwards.crend ()
2021-09-22T18:38:44.2496810Z     Which is: 16-byte object <70-45 D3-09 A8-7F 00-00 70-45 D3-09 A8-7F 00-00>
2021-09-22T18:38:44.4667400Z [  FAILED  ] ledger_walker.ladder_geometry (7274 ms)

https://github.com/nanocurrency/nano-node/runs/3678698743?check_suite_focus=true#step:6:945

[theohax]

Issue addressed in #3497 -- but not with an actual fix, just a guess at improving the test case.

The failure indicated above I wasn't able to reproduce, neither locally nor in the CI (OSX & Linux).

I suggest to close the issue for now and keep an eye open on the test case to see if it ever fails again in the CI.