Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not all versions of GCC support -fsanitize-blacklist #1656

Closed
rkeene opened this issue Jan 28, 2019 · 3 comments
Closed

Not all versions of GCC support -fsanitize-blacklist #1656

rkeene opened this issue Jan 28, 2019 · 3 comments
Assignees
@argakiig
Labels
build-error
Milestone
V19.0

Comments

@rkeene
Copy link
Contributor

rkeene commented Jan 28, 2019

TSAN blacklist support (added in #1637) is not available in all versions of GCC.
@cryptocode
Copy link
Contributor

cryptocode commented Jan 28, 2019 •
edited
Loading

@rkeene Should I introduce a cmake flag for it? Without it, tsan is just too noisy to be practical.
edit: could maybe just add it to #1655

@rkeene
Copy link
Contributor Author

rkeene commented Jan 28, 2019

Ideally the build system would detect whether or not the compiler supports this.

@wezrule wezrule mentioned this issue Feb 8, 2019
Merged
@zhyatt zhyatt added this to the V18.0 milestone Feb 11, 2019
@zhyatt zhyatt modified the milestones: V18.0, V19.0 Feb 22, 2019
@zhyatt zhyatt assigned argakiig and unassigned wezrule Feb 22, 2019
@wezrule
Copy link
Contributor

wezrule commented Apr 27, 2019

gcc does not support this option, but you can use a suppressions file in the TSAN_OPTIONS environment variable:
#1941
Documentation: https://github.com/nanocurrency/nano-node/wiki/Testing

@wezrule wezrule closed this as completed Apr 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@argakiig argakiig

Labels
build-error
Projects
None yet
Milestone
V19.0
Development

No branches or pull requests
5 participants
@wezrule @zhyatt @rkeene @argakiig @cryptocode