Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo.toml should be added to gitignore and removed from history #986

Open
IohannRabeson opened this issue Jan 27, 2025 · 1 comment · May be fixed by #987 or #988
Open

Cargo.toml should be added to gitignore and removed from history #986

IohannRabeson opened this issue Jan 27, 2025 · 1 comment · May be fixed by #987 or #988

Comments

@IohannRabeson
Copy link

IohannRabeson commented Jan 27, 2025

It cause issue: I had to call cargo update in order to make it use hotglsl v0.2.0 which break the build because ShaderType does not exist since hotglsl switch to use naga instead of glsl-to-spirv.

The project is still using hotglsl v0.1.0 (which does not build on Mac M1) even if its specified in Cargo.toml to use the latest commit in master branch in the repository https://github.com/nannou-org/hotglsl because someone forgot to submit the Cargo.lock updated I guess.
The rule for Cargo.lock is to add it to .gitignore for libraries and include it in history for binaries.

edit: I see in the history 624a596 where it says "including the Cargo.lock in git tracking should not cause any major issues" but still I had to debug that in order to make it build.

@IohannRabeson
Copy link
Author

I provided 2 differents fixes:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant