How to add extra tags?

[dedupely]

I'm using docker swarm and want to be able to revert to the last image rev.

I notice that roger doesn't give the option to set the tag and just used the branch name by default. That's fine, but I also want BRANCH_NAME-REV and then update it in the swarm after the docker registry push.

How would I do this?

[odino]

Hi @dedupely! There is no such functionality at the moment but, if you're down to hack and send a PR, we'd be happy to review it!

This is where I'd suggest looking at.

Cheers!

[dedupely]

Might just do that. What do you think? A hook called "post/pre-registry-push"? I need to read docker docs to see if one can add multiple tags to an already pushed image without pushing it again. If this works it will be pretty clean.

…

On Sun, Mar 10, 2019, 2:39 AM Alessandro Nadalin ***@***.***> wrote: Hi @dedupely <https://github.com/dedupely>! There is no such functionality at the moment but, if you're down to hack and send a PR, we'd be happy to review it! This <https://github.com/namshi/roger/blob/master/src/builder.js#L131> is where I'd suggest looking at. Cheers! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#52 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/Acu5f0z_b5kOrO57ybcwjlKZlBCDFFbHks5vVMSxgaJpZM4bl51s> .

[dedupely]

Or better yet a tag option. I need to have post push to trigger a swarm update. So a hook plus a tag name option will probably be part of the pr. On Sun, Mar 10, 2019, 10:03 AM Clinton Skakun <[email protected]> wrote:

…

Might just do that. What do you think? A hook called "post/pre-registry-push"? I need to read docker docs to see if one can add multiple tags to an already pushed image without pushing it again. If this works it will be pretty clean. On Sun, Mar 10, 2019, 2:39 AM Alessandro Nadalin ***@***.***> wrote: > Hi @dedupely <https://github.com/dedupely>! There is no such > functionality at the moment but, if you're down to hack and send a PR, we'd > be happy to review it! > > This <https://github.com/namshi/roger/blob/master/src/builder.js#L131> > is where I'd suggest looking at. > > Cheers! > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#52 (comment)>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/Acu5f0z_b5kOrO57ybcwjlKZlBCDFFbHks5vVMSxgaJpZM4bl51s> > . >

[JonathanHolvey]

Did you get anywhere with this? I'm looking at implementing some tagging features to do with semantic versioning:

• Removing a leading V from a semver tag name
• Pushing multiple tags to the registry for major, minor and bugfix versions

I'd like to achieve this without affecting the tag displayed in the build process, so a pre registry push hook would be great.

I'm also thinking a server config key tagging could be used to store the options. Would this work with what you're proposing?

[dedupely]

No I ended up keeping my building in docker hub.

…

On Sun, May 19, 2019, 1:47 AM Jonathan Holvey ***@***.***> wrote: Did you get anywhere with this? I'm looking at implementing some tagging features to do with semantic versioning: - Removing a leading V from a semver tag name - Pushing multiple tags to the registry for major, minor and bugfix versions I'd like to achieve this without affecting the tag displayed in the build process, so a pre registry push hook would be great. I'm also thinking a server config key tagging could be used to store the options. Would this work with what you're proposing? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#52?email_source=notifications&email_token=AHF3S75YPZVLTRJNP53HYS3PWDZXJA5CNFSM4G4XTVWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVW37RA#issuecomment-493731780>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHF3S76FMF2IJO2G4LZ7NYTPWDZXJANCNFSM4G4XTVWA> .