-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multiple recipient COSE operations #10
Conversation
Pull Request Test Coverage Report for Build 3981217710Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
8f0a432
to
ae08517
Compare
3e2e8cb
to
69ef114
Compare
79681e0
to
75f1696
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some initial comments for the parts that I got to read up until now (will do the rest as well as a deeper pass over the entire PR tomorrow).
I assume that there won't be any large comments for the remainder either, as we have already discussed the general idea behind the cipher implementations in person.
Co-authored-by: Hugo Hakim Damer <[email protected]>
974917a
to
c5f91fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's the second part of the review. As already predicted, I did not find any glaring issues that would make larger changes necessary.
If there are any remaining larger issues, I'd assume that we'd find them when we add actual implementations.
One suggestion regarding the release process for 0.4.0: In order to ensure that we don't ship a release that isn't actually functional, I'd hold off on releasing until we have at least one implementation that isn't FakeCrypto
and actually links to an actual crypto library.
(I'll try to make time to write a proof-of-concept for either OpenSSL or RustCrypto this week)
eb78ca9
to
b2a64d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(See a few very minor comments/suggestions below.)
Co-authored-by: Jan Romann <[email protected]>
177a593
to
bdcb6ad
Compare
@JKRhb Thank you for the review! All points should now have been resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor remark. Aside from that, there's not really much left to comment on ^^
LGTM.
22e742b
to
c03d64d
Compare
This rewrites the existing ciphers to work without requiring a
self
reference (instead taking in a key), and adds support forCoseSign
,CoseEncrypt
, andCoseMac
rather than just the single-recipient variants. For this purpose, token methods with the suffix_multiple
have also been implemented. Tests and documentation have been written for all new traits, macros, functions, and methods.