From 0232acf6b1e7177603b3d9b631877fab91b12778 Mon Sep 17 00:00:00 2001 From: Piotr Dubiel Date: Mon, 8 Apr 2019 17:32:57 +0200 Subject: [PATCH] Add 0.59.3 also --- .travis.yml | 7 ++++++ README.md | 1 + .../rn-0.59.3/0001-minSdkVersion-bump.patch | 13 +++++++++++ .../0002-gradle-espresso-config.patch | 23 +++++++++++++++++++ 4 files changed, 44 insertions(+) create mode 100644 integration-tests/patches/rn-0.59.3/0001-minSdkVersion-bump.patch create mode 100644 integration-tests/patches/rn-0.59.3/0002-gradle-espresso-config.patch diff --git a/.travis.yml b/.travis.yml index 12e87b82..0dcb188e 100644 --- a/.travis.yml +++ b/.travis.yml @@ -97,6 +97,13 @@ matrix: # Integration tests for different React Native versions + - <<: *android_job_template + name: 'Integrate with RN 0.59.3 Android' + env: RN_VERSION=0.59.3 + - <<: *ios_job_template + name: 'Integrate with RN 0.59.3 iOS' + env: RN_VERSION=0.59.3 + - <<: *android_job_template name: 'Integrate with RN 0.59.1 Android' env: RN_VERSION=0.59.1 diff --git a/README.md b/README.md index 0d5e0817..b05e1a96 100644 --- a/README.md +++ b/README.md @@ -27,6 +27,7 @@ What this library does NOT support: | React Native | 1.0.3 | | ------------ | ------------------ | +| 0.59.3 | :white_check_mark: | | 0.59.1 | :white_check_mark: | | 0.59.0 | :white_check_mark: | | 0.58.3 | :white_check_mark: | diff --git a/integration-tests/patches/rn-0.59.3/0001-minSdkVersion-bump.patch b/integration-tests/patches/rn-0.59.3/0001-minSdkVersion-bump.patch new file mode 100644 index 00000000..909cabde --- /dev/null +++ b/integration-tests/patches/rn-0.59.3/0001-minSdkVersion-bump.patch @@ -0,0 +1,13 @@ +diff --git a/integration-tests/Setup/android/build.gradle b/integration-tests/Setup/android/build.gradle +index c6e7c7c..24b752a 100644 +--- a/integration-tests/Setup/android/build.gradle ++++ b/integration-tests/Setup/android/build.gradle +@@ -3,7 +3,7 @@ + buildscript { + ext { + buildToolsVersion = "28.0.3" +- minSdkVersion = 16 ++ minSdkVersion = 18 + compileSdkVersion = 28 + targetSdkVersion = 28 + supportLibVersion = "28.0.0" diff --git a/integration-tests/patches/rn-0.59.3/0002-gradle-espresso-config.patch b/integration-tests/patches/rn-0.59.3/0002-gradle-espresso-config.patch new file mode 100644 index 00000000..2f991ea1 --- /dev/null +++ b/integration-tests/patches/rn-0.59.3/0002-gradle-espresso-config.patch @@ -0,0 +1,23 @@ +diff --git a/integration-tests/Setup/android/app/build.gradle b/integration-tests/Setup/android/app/build.gradle +index 1f01fa3..207d72c 100644 +--- a/integration-tests/Setup/android/app/build.gradle ++++ b/integration-tests/Setup/android/app/build.gradle +@@ -103,6 +103,7 @@ android { + targetSdkVersion rootProject.ext.targetSdkVersion + versionCode 1 + versionName "1.0" ++ testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner" + } + splits { + abi { +@@ -138,6 +139,10 @@ dependencies { + implementation fileTree(dir: "libs", include: ["*.jar"]) + implementation "com.android.support:appcompat-v7:${rootProject.ext.supportLibVersion}" + implementation "com.facebook.react:react-native:+" // From node_modules ++ testImplementation 'junit:junit:4.12' ++ androidTestImplementation 'androidx.test.espresso:espresso-core:3.1.0' ++ androidTestImplementation 'androidx.test:runner:1.1.0' ++ androidTestImplementation 'androidx.test:rules:1.1.0' + } + + // Run this once to be able to run the application with BUCK