Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(socials): Add margin top on socials page #56

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

rodneyosodo
Copy link
Contributor

They social heading was be obstructed

They social heading was be obstructed
Copy link

vercel bot commented Oct 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gophercon2024 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 1:41pm

@rodneyosodo
Copy link
Contributor Author

@nutcas3
Copy link
Contributor

nutcas3 commented Oct 7, 2024

Kindly add an image for us to see the change

@nutcas3 nutcas3 self-requested a review October 7, 2024 10:44
@rodneyosodo
Copy link
Contributor Author

Isn't it deployed to vercel?

@nutcas3
Copy link
Contributor

nutcas3 commented Oct 7, 2024

Yes it is bit vercel pricing is crazy when you add anotherperson

@nutcas3
Copy link
Contributor

nutcas3 commented Oct 7, 2024

We did that by the design so this means you will have to make all.of them to be similar for consistency

@nutcas3 nutcas3 closed this Oct 8, 2024
@rodneyosodo
Copy link
Contributor Author

@nutcas3 This should not be done on every page since other pages are okay. This is the recorded session https://jam.dev/c/f764fbbd-574d-4433-9d7e-d532d5aa0d4f

@nutcas3 nutcas3 reopened this Oct 8, 2024
@nutcas3 nutcas3 merged commit 7abfb24 into nairobi-gophers:main Oct 8, 2024
2 of 4 checks passed
@rodneyosodo rodneyosodo deleted the fix/socials-mt branch October 22, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants