You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have created a minimal repo on this link to demonstrate when the tooltip breaks. https://github.com/alexmasita/ember-tippy-test.git. It seems that when you create any ember modifier such as 'ember g modifier on-entry', this tooltip component fails to work and the tooltips fail to show. However, as you will see on the repo link provided, when you delete the modifier on the terminal via 'ember d modifier on-entry', and rerun the application, this tooltip works again. I thought it was perhaps a keyword issue and changed the name of the modifier but it still broke this addon. I see in the console multiple deprecation warnings such as "DEPRECATION: ember-modifier (in TippyForComponentModifier at Error
" and " The didInstall, didReceiveArguments, and didUpdateArguments hooks are deprecated. Use the new modify hook instead. [deprecation id: ember-modifier.use-modify] This will be removed in ember-modifier 4.0.0.". Thanks for the great plugin.
The text was updated successfully, but these errors were encountered:
Thanks for the minimal repo. I see that you use ember-modifier 4.x and ember-tippy 2.x. Ember-tippy 2.x uses the old modifier api, which was removed in ember-modifier 4.0.0 (as written in the deprecation you mentioned above).
Please try ember-tippy 3: ember install [email protected].
The README.md still refers to ember-modifier ^3.0.0 dependency, but it seems [email protected] works okay with ember-modifier 4.1.0 - at least the tooltip in your minimal repo appears to be working.
The odd situation about ember g modifier on-entry and ember d modifier on-entry is related to how ember's build system resolves dependencies in such cases:
I have created a minimal repo on this link to demonstrate when the tooltip breaks. https://github.com/alexmasita/ember-tippy-test.git. It seems that when you create any ember modifier such as 'ember g modifier on-entry', this tooltip component fails to work and the tooltips fail to show. However, as you will see on the repo link provided, when you delete the modifier on the terminal via 'ember d modifier on-entry', and rerun the application, this tooltip works again. I thought it was perhaps a keyword issue and changed the name of the modifier but it still broke this addon. I see in the console multiple deprecation warnings such as "DEPRECATION: ember-modifier (in TippyForComponentModifier at Error
" and " The
didInstall
,didReceiveArguments
, anddidUpdateArguments
hooks are deprecated. Use the newmodify
hook instead. [deprecation id: ember-modifier.use-modify] This will be removed in ember-modifier 4.0.0.". Thanks for the great plugin.The text was updated successfully, but these errors were encountered: