Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance(#197): naming_push_empty_protection can be set in ClientProps #198

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

CherishCai
Copy link
Collaborator

close #197

@CherishCai CherishCai added the chore Chore for code label Sep 27, 2023
@CherishCai CherishCai requested a review from onewe September 27, 2023 01:47
@CherishCai CherishCai added enhancement New feature or request and removed chore Chore for code labels Sep 27, 2023
@CherishCai CherishCai changed the title chore(#197): naming_push_empty_protection can be set in ClientProps Enhance(#197): naming_push_empty_protection can be set in ClientProps Sep 27, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (26f52ba) 15.90% compared to head (e9bdf6c) 15.89%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #198      +/-   ##
==========================================
- Coverage   15.90%   15.89%   -0.02%     
==========================================
  Files          49       49              
  Lines        2829     2838       +9     
==========================================
+ Hits          450      451       +1     
- Misses       2379     2387       +8     
Files Coverage Δ
...c/config/message/request/config_publish_request.rs 0.00% <0.00%> (ø)
src/naming/mod.rs 0.00% <0.00%> (ø)
src/api/plugin/auth/mod.rs 0.00% <0.00%> (ø)
src/lib.rs 52.77% <22.22%> (-1.77%) ⬇️
src/api/props.rs 42.10% <15.38%> (-6.38%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@onewe onewe merged commit 89b2111 into main Sep 27, 2023
@CherishCai CherishCai deleted the chore_naming_push_empty_protection branch September 27, 2023 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance: Naming 防推空逻辑,提供环境变量设置是否开启
3 participants