Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify comitup/network connection feedback logic #378

Open
pguyot opened this issue Jun 11, 2022 · 0 comments
Open

Simplify comitup/network connection feedback logic #378

pguyot opened this issue Jun 11, 2022 · 0 comments

Comments

@pguyot
Copy link
Collaborator

pguyot commented Jun 11, 2022

Comitup callback script could be replaced with something sending a packet for nabd to process.

printf '{"type":"comitup","callback":"%s"}', "$1"

Likewise, network connectivity test on transition to idle should be:

  • replaced with a mix of network tests, as TCP on port 53 can be blocked (e.g. ICMP, hostname resolution, HTTP, HTTPS)
  • happen much less frequently and on a regular basis
  • be paired with a pipe on a command such as "ip monitor link" to monitor link changes (that would trigger a new connectivity test).

Eventually, both systems should send events to services that need to connect to the internet, such as nabweatherd and nabairqualityd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant