feat(core): Add workflowId filter to the test-definitions endpoint (no-changelog) #11831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
OlegIvaniv
approved these changes
Nov 26, 2024
Comment on lines
+21
to
+26
| if (!accessibleWorkflowIds.includes(options.filter.workflowId as string)) { | ||
| throw new ForbiddenError('User does not have access to the workflow'); | ||
| } | ||
|
|
||
| where.workflow = { | ||
| id: options.filter.workflowId as string, |
There was a problem hiding this comment.
Could we improve the type of options here instead of coercing it to string 2x?
There was a problem hiding this comment.
That would be great to do for all places using filter middleware. I will check it later
|
|
n8n
|
||||||||||||||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
ai-456-api-add-option-to-filter-test-definitions-by-a-specific
|
| Run status |
|
| Run duration | 38m 38s |
| Commit |
|
| Committer | Eugene Molodkin |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
1
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
280
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
45-workflow-selector-parameter.cy.ts • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Workflow Selector Parameter > should render add resource option and redirect to the correct route when clicked |
Test Replay
Screenshots
Video
|
|
The first 5 failed specs are shown, see all 49 specs in Cypress Cloud.
e2e/30-langchain.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Langchain Integration > should be able to open and execute Agent node |
Test Replay
Screenshots
Video
|
|
|
|
burivuhster
force-pushed
the
ai-456-api-add-option-to-filter-test-definitions-by-a-specific
branch
from
4057ed4
to
0b94403
Compare
burivuhster
force-pushed
the
ai-456-api-add-option-to-filter-test-definitions-by-a-specific
branch
from
0b94403
to
73df6de
Compare
burivuhster
deleted the
ai-456-api-add-option-to-filter-test-definitions-by-a-specific
branch
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds filter by
workflowIdto the/test-definitionslist endpoint.Related Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)