fix(core): Make push work for waiting webhooks #11678
Merged
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netroy
force-pushed
the
CAT-328-make-push-work-for-waiting-webhooks
branch
from
6209a72
to
af37252
Compare
n8n-assistant
bot
added
core
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
ivov
approved these changes
Nov 11, 2024
| @@ -495,6 +495,11 @@ function hookFunctionsSave(): IWorkflowExecuteHooks { | |||
| retryOf: this.retryOf, | |||
| }); | |||
|
|
|||
| // When going into the waiting state, store the pushRef in the execution-data | |||
There was a problem hiding this comment.
Nit - Ideally we should comment on the why rather than the what.
There was a problem hiding this comment.
This code will be deleted in CAT-251
|
✅ All Cypress E2E specs passed |
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
CAT-328-make-push-work-for-waiting-webhooks
|
| Run status |
|
| Run duration | 04m 20s |
| Commit |
|
| Committer | कारतोफ्फेलस्क्रिप्ट™ |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
466
|
| View all changes introduced in this branch ↗︎ | |
Merged
|
Got released with |
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When an execution goes into the waiting state, the execution context is destroyed, since it could be a while before the execution gets resumed. This and the fact that
pushRefhas so far been kept on the execution context, and not persisted anywhere, has led to push not working in the UI once the execution goes into the waiting state.This has led to us adding a polling mechanism , which is now creating race condition when
EXECUTIONS_DATA_SAVE_ON_SUCCESSis set tonone.Instead of trying to fix the race condition, we should remove the polling instead, and ensure that push works for all manual executions.
Related Linear tickets, Github issues, and Community forum posts
CAT-328
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)