feat(core): Add internal API for test definitions (no-changelog) #11591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
burivuhster
force-pushed
the
ai-422-api-endpoint-evaluationtests-crud
branch
from
97404fd to
0b0cde4
Compare
burivuhster
changed the title
jeanpaul
reviewed
Nov 7, 2024
packages/cli/src/databases/repositories/test-definition.repository.ee.ts
Outdated
Show resolved
Hide resolved
packages/cli/src/databases/repositories/test-definition.repository.ee.ts
Show resolved
Hide resolved
tomi
reviewed
Nov 7, 2024
packages/cli/test/integration/evaluation/test-definitions.api.test.ts
Outdated
Show resolved
Hide resolved
| // Fetch the first page | ||
| let resp = await authOwnerAgent.get('/evaluation/test-definitions?take=10'); | ||
| expect(resp.statusCode).toBe(200); | ||
| expect(resp.body.data.count).toBe(15); |
There was a problem hiding this comment.
We should probably also test that the returned test definitions are also correct (ids should be enough)
There was a problem hiding this comment.
I made an attempt, but could not quickly come up with a reliable way to add tests in a specific order (the retrieval is ordered by createdAt field), so decided to postpone it
packages/cli/test/integration/evaluation/test-definitions.api.test.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Tomi Turtiainen <[email protected]>
Co-authored-by: Tomi Turtiainen <[email protected]>
|
✅ All Cypress E2E specs passed |
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
ai-422-api-endpoint-evaluationtests-crud
|
| Run status |
|
| Run duration | 04m 22s |
| Commit |
|
| Committer | Eugene Molodkin |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
462
|
| View all changes introduced in this branch ↗︎ | |
|
Got released with |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a set of internal API endpoints to work with Test Definitions.
Related Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)