Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(HTTP Request Tool Node): Relax binary data detection #13048

Conversation

OlegIvaniv
Copy link
Contributor

Summary

Replaces strict MIME type validation with a simpler binary check to support custom content types like application/custom+json. Fixes #12712.

Changes

  • Remove MIME package content-type validation
  • Add basic binary detection for null characters
  • Add tests for binary detection edge cases

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...des-langchain/nodes/tools/ToolHttpRequest/utils.ts 90.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Feb 4, 2025
Copy link
Contributor

@burivuhster burivuhster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🔥

Copy link
Contributor

github-actions bot commented Feb 5, 2025

✅ All Cypress E2E specs passed

Copy link

cypress bot commented Feb 5, 2025

n8n    Run #9130

Run Properties:  status check passed Passed #9130  •  git commit c3c8a580c5: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 OlegIvaniv 🗃️ e2e/*
Project n8n
Branch Review ai-608-community-issue-ai-agent-http-request-node-treats-custom
Run status status check passed Passed #9130
Run duration 04m 49s
Commit git commit c3c8a580c5: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 OlegIvaniv 🗃️ e2e/*
Committer Oleg Ivaniv
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 5
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 433
View all changes introduced in this branch ↗︎

@OlegIvaniv OlegIvaniv merged commit b67a003 into master Feb 5, 2025
37 checks passed
@OlegIvaniv OlegIvaniv deleted the ai-608-community-issue-ai-agent-http-request-node-treats-custom branch February 5, 2025 11:14
This was referenced Feb 5, 2025
@janober
Copy link
Member

janober commented Feb 6, 2025

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AI Agent HTTP Request Node treats custom json content-type declarations as binary
3 participants