Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Allow to re-open sub-connection node creator if already active #13041

Conversation

OlegIvaniv
Copy link
Contributor

Summary

These changes address the issue where the sub-node node creator view(for example tools) section remained visible instead of switching to the appropriate panel when clicking on plus connection.

  • Resetting the view stack before pushing a new view so that previous panels are cleared.
  • Updating the logic in the node creator store to use AI_UNCATEGORIZED_CATEGORY when the connection type is not Main.
  • Adding tests to verify the behavior for both Main and non-Main connection types, as well as handling cases with no source node.
CleanShot.2025-02-04.at.12.46.43.mp4

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Feb 4, 2025
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 63.04348% with 17 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ents/Node/NodeCreator/composables/useViewStacks.ts 58.53% 17 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Member

@alexgrozav alexgrozav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🤩

Copy link
Contributor

github-actions bot commented Feb 5, 2025

✅ All Cypress E2E specs passed

Copy link

cypress bot commented Feb 5, 2025

n8n    Run #9134

Run Properties:  status check passed Passed #9134  •  git commit 0bdf0d24dd: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 OlegIvaniv 🗃️ e2e/*
Project n8n
Branch Review ai-564-bug-clicking-on-the-icon-doesnt-show-the-right-section-of
Run status status check passed Passed #9134
Run duration 04m 32s
Commit git commit 0bdf0d24dd: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 OlegIvaniv 🗃️ e2e/*
Committer Oleg Ivaniv
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 5
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 433
View all changes introduced in this branch ↗︎

@OlegIvaniv OlegIvaniv merged commit 16d59e9 into master Feb 5, 2025
37 checks passed
@OlegIvaniv OlegIvaniv deleted the ai-564-bug-clicking-on-the-icon-doesnt-show-the-right-section-of branch February 5, 2025 15:45
This was referenced Feb 5, 2025
@janober
Copy link
Member

janober commented Feb 6, 2025

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants