feat: Add support for client credentials with Azure Log monitor #13038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
dana-gill
approved these changes
Feb 4, 2025
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
node-2322-update-log-monitor-to-support-client-creds
|
| Run status |
|
| Run duration | 04m 40s |
| Commit |
|
| Committer | Jonathan Bennetts |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
5
|
Skipped
|
0
|
Passing
|
433
|
| View all changes introduced in this branch ↗︎ | |
|
✅ All Cypress E2E specs passed |
Joffcom
deleted the
node-2322-update-log-monitor-to-support-client-creds
branch
riascho
pushed a commit
that referenced
this pull request
Feb 5, 2025
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds Client Credential support for Azure Log monitor cred only node.
Changes
/.defaultat the endThis is not very well documented on the MS side so took some trial and error with a customer to get it working. It is possible that in the future we may need to add more Resource options if they come up but these are the main 4 I found in the documentation.
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-2322/update-log-monitor-to-support-client-creds
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)