fix(core): Do not enable strict type validation by default for resource mapper #13037
+144
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elsmr
added
the
release/backport
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
dana-gill
approved these changes
Feb 4, 2025
|
✅ All Cypress E2E specs passed |
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
node-2249-community-issue-sql-data-type-error
|
| Run status |
|
| Run duration | 04m 59s |
| Commit |
|
| Committer | Elias Meire |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
5
|
Skipped
|
0
|
Passing
|
433
|
| View all changes introduced in this branch ↗︎ | |
n8n-assistant
bot
added
core
elsmr
added a commit
that referenced
this pull request
Feb 4, 2025
elsmr
added a commit
that referenced
this pull request
Feb 4, 2025
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #11837 strict validation was turned on by default for resource mappers, breaking existing workflows that relied on type conversion.
This PR reverts to the old behavior (strict=false) when the resource mapper has no
attemptToConvertTypesoption set.Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-2249/community-issue-sql-data-type-error
fixes #12651
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)