Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(OpenAI Chat Model Node, OpenAI Node): Include o3 models in model selection #13005

Conversation

jeanpaul
Copy link
Contributor

@jeanpaul jeanpaul commented Feb 3, 2025

Summary

The model-filters didn't include the o3 models yet. This change fixes that. This allows you to use o3-mini now.

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Feb 3, 2025
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link
Contributor

github-actions bot commented Feb 3, 2025

✅ All Cypress E2E specs passed

Copy link

cypress bot commented Feb 3, 2025

n8n    Run #9080

Run Properties:  status check passed Passed #9080  •  git commit 342dc103c0: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 jeanpaul 🗃️ e2e/*
Project n8n
Branch Review ai-658-adjust-the-filtering-of-the-openai-models-to-include-o3
Run status status check passed Passed #9080
Run duration 04m 24s
Commit git commit 342dc103c0: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 jeanpaul 🗃️ e2e/*
Committer JP van Oosten
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 5
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 433
View all changes introduced in this branch ↗︎

@jeanpaul jeanpaul merged commit 37d152c into master Feb 3, 2025
37 checks passed
@jeanpaul jeanpaul deleted the ai-658-adjust-the-filtering-of-the-openai-models-to-include-o3 branch February 3, 2025 11:56
riascho pushed a commit that referenced this pull request Feb 5, 2025
This was referenced Feb 5, 2025
@janober
Copy link
Member

janober commented Feb 6, 2025

Got released with [email protected]

@efnogron
Copy link

efnogron commented Feb 6, 2025

Thank you! please add the ability to modify reasoning effort! there is massive performance variance between the different options! :)

@msjfuria
Copy link

msjfuria commented Feb 6, 2025

please add modify reasoning effort +1

@aiexpertacademy
Copy link

aiexpertacademy commented Feb 7, 2025

yes, please add reasoning effort. openAI defaults to "medium" if no reasoning effort is specified. From openAI documentation:

reasoning_effort
string or null

Optional
Defaults to medium
o1 and o3-mini models only

Constrains effort on reasoning for reasoning models. Currently supported values are low, medium, and high. Reducing reasoning effort can result in faster responses and fewer tokens used on reasoning in a response.

Ref:

https://platform.openai.com/docs/guides/reasoning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants