Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(n8n Form Node): Respond with Text #12979

Merged
merged 5 commits into from
Feb 4, 2025
Merged

Conversation

dana-gill
Copy link
Contributor

Summary

Respond with text upon form completion. Using html is possible

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-2341/respond-with-text

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@dana-gill dana-gill changed the title feat(n8n Form Completion): Respond with Text feat(n8n Form Node): Respond with Text Jan 31, 2025
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team node/improvement New feature or request labels Jan 31, 2025
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 80.43478% with 9 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/nodes-base/nodes/Form/formNodeUtils.ts 59.09% 9 Missing ⚠️

📢 Thoughts on this report? Let us know!

@dana-gill dana-gill marked this pull request as draft January 31, 2025 16:37
@dana-gill dana-gill marked this pull request as ready for review February 3, 2025 08:58
Copy link
Contributor

@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉
I like splitting out the code into separate files 👍

Copy link
Contributor

github-actions bot commented Feb 4, 2025

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Feb 4, 2025

n8n    Run #9124

Run Properties:  status check failed Failed #9124  •  git commit 182fc150be: 🌳 master 🖥️ browsers:node18.12.0-chrome107 🤖 PR User 🗃️ e2e/*
Project n8n
Branch Review master
Run status status check failed Failed #9124
Run duration 04m 40s
Commit git commit 182fc150be: 🌳 master 🖥️ browsers:node18.12.0-chrome107 🤖 PR User 🗃️ e2e/*
Committer Dana
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 5
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 340
View all changes introduced in this branch ↗︎

Tests for review

Failed  39-projects.cy.ts • 1 failed test

View Output Video

Test Artifacts
Projects > when starting from scratch > should move resources between projects Test Replay Screenshots Video
Failed  27-two-factor-authentication.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  34-template-credentials-setup.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  17-workflow-tags.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  47-subworkflow-debugging.cy.ts • 0 failed tests

View Output

Test Artifacts

The first 5 failed specs are shown, see all 33 specs in Cypress Cloud.

Flakiness  e2e/39-projects.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Projects > when starting from scratch > should create sub-workflow and credential in the sub-workflow in the same project Test Replay Screenshots Video

@dana-gill dana-gill force-pushed the node-2341-respond-with-text branch from e46aa8b to b04df18 Compare February 4, 2025 16:22
Copy link
Contributor

github-actions bot commented Feb 4, 2025

✅ All Cypress E2E specs passed

Copy link
Contributor

github-actions bot commented Feb 4, 2025

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link
Contributor

github-actions bot commented Feb 4, 2025

✅ All Cypress E2E specs passed

@dana-gill dana-gill merged commit 182fc15 into master Feb 4, 2025
37 checks passed
@dana-gill dana-gill deleted the node-2341-respond-with-text branch February 4, 2025 17:35
riascho pushed a commit that referenced this pull request Feb 5, 2025
This was referenced Feb 5, 2025
@janober
Copy link
Member

janober commented Feb 6, 2025

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants