Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): Show fixed collection parameter issues in UI #12899

Merged
merged 9 commits into from
Jan 29, 2025

Conversation

MiloradFilipovic
Copy link
Contributor

@MiloradFilipovic MiloradFilipovic commented Jan 28, 2025

Summary

  • Fixed collection parameters now show issues alongside parameter label:
    image
  • Also updating workflow tool warning copy based on this feedback and improving InputLabel elements alignment

Related Linear tickets, Github issues, and Community forum posts

Closes ADO-3124

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@MiloradFilipovic MiloradFilipovic self-assigned this Jan 28, 2025
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jan 28, 2025
@MiloradFilipovic MiloradFilipovic force-pushed the ADO-3124-add-fixed-collection-issues branch from 608d8fb to b4f704e Compare January 29, 2025 08:35
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@CharlieKolb CharlieKolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link

cypress bot commented Jan 29, 2025

n8n    Run #9027

Run Properties:  status check passed Passed #9027  •  git commit 6c1d32eb51: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 MiloradFilipovic 🗃️ e2e/*
Project n8n
Branch Review ADO-3124-add-fixed-collection-issues
Run status status check passed Passed #9027
Run duration 04m 27s
Commit git commit 6c1d32eb51: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 MiloradFilipovic 🗃️ e2e/*
Committer Milorad FIlipović
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 5
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 432
View all changes introduced in this branch ↗︎

@MiloradFilipovic MiloradFilipovic merged commit 12d686c into master Jan 29, 2025
41 checks passed
@MiloradFilipovic MiloradFilipovic deleted the ADO-3124-add-fixed-collection-issues branch January 29, 2025 14:50
This was referenced Feb 5, 2025
@janober
Copy link
Member

janober commented Feb 6, 2025

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants