-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow multi API creation via the UI #12845
Conversation
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job. A few small comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff, couple comments
@@ -1844,6 +1848,14 @@ | |||
"settings.api.view.more-details": "You can find more details in", | |||
"settings.api.view.external-docs": "the API documentation", | |||
"settings.api.view.error": "Could not check if an api key already exists.", | |||
"settings.api.view.modal.form.label": "Label", | |||
"settings.api.view.modal.form.label.placeholder": "e.g Internal Project", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe rather something about credentials?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
credentials? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooops sorry meant API keys :D Instead of projects
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought it was copy pasted from some project creation modal translation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for addressing 🙇 🚀
n8n
|
Project |
n8n
|
Branch Review |
update-ui-to-multiple-apis
|
Run status |
|
Run duration | 04m 24s |
Commit |
|
Committer | Ricardo Espinoza |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
2
|
|
5
|
|
0
|
|
430
|
View all changes introduced in this branch ↗︎ |
✅ All Cypress E2E specs passed |
Got released with |
Summary
Phase 2 of the initiative to have scoped and expirable API keys.
settingsApiView
to support multiple APIs.Demo
Related Linear tickets, Github issues, and Community forum posts
https://www.notion.so/n8n/Public-API-scopes-and-expiration-51f6bad3305f4397869dc71b95ac2ceb?pvs=4
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)