-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): Restore old names for pruning config keys #11782
Conversation
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I have a config.json
file like this:
{
"executions": {
"pruneData": true,
"pruneDataMaxAge": 30,
"pruneDataMaxCount": 100
}
}
and I start n8n with N8N_CONFIG_FILES=config.json pn start
it works on 1.66.0
but not with latest master or this branch. The pruning config needs to be under executions
. Also could we add tests for this so it doesn't break a seconds time?
Good catch! Fixed
Let's add tests for this separately for all remaining schema keys? As it's a more general issue and we should include this PR in today's release. |
Fair enough. Ideally we should include a test for the case that broke in the first place. But we can merge this to get it on the release. Should add the tests after this so we don't forget |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
n8n Run #7994
Run Properties:
|
Project |
n8n
|
Branch Review |
restore-old-names-for-pruning-config-keys
|
Run status |
Passed #7994
|
Run duration | 04m 37s |
Commit |
82aa71dbc3: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 ivov 🗃️ e2e/*
|
Committer | Iván Ovejero |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
1
|
Pending |
0
|
Skipped |
0
|
Passing |
475
|
View all changes introduced in this branch ↗︎ |
✅ All Cypress E2E specs passed |
Got released with |
Summary
#11507 renamed the poorly named pruning config keys in the schema object, but it turns out the internal structure of the schema object is being relied on externally via
N8N_CONFIG_FILES
, so this PR renames back those keys until we can deprecate and drop this env var in v2.Related Linear tickets, Github issues, and Community forum posts
8gears/n8n-helm-chart#125
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)