Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(YouTube Node): Issue in published before and after dates filters #11741

Conversation

ShireenMissi
Copy link
Contributor

Summary

This PR fixes the issue in Published Date before and after

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-2027/youtube-published-after-published-before-date-filters-error

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@ShireenMissi ShireenMissi changed the title fix(Youtube Node): Issue in published before and after dates filters fix(YouTube Node): Issue in published before and after dates filters Nov 14, 2024
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Nov 14, 2024
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...es/nodes-base/nodes/Google/YouTube/YouTube.node.ts 0.00% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link

cypress bot commented Nov 14, 2024

n8n    Run #7892

Run Properties:  status check passed Passed #7892  •  git commit a4d0c867ae: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 ShireenMissi 🗃️ e2e/*
Project n8n
Branch Review node-2027-youtube-published-after-published-before-date-filters-error
Run status status check passed Passed #7892
Run duration 04m 22s
Commit git commit a4d0c867ae: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 ShireenMissi 🗃️ e2e/*
Committer Shireen Missi
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 470
View all changes introduced in this branch ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@ShireenMissi ShireenMissi merged commit 7381c28 into master Nov 14, 2024
35 checks passed
@ShireenMissi ShireenMissi deleted the node-2027-youtube-published-after-published-before-date-filters-error branch November 14, 2024 16:02
@github-actions github-actions bot mentioned this pull request Nov 20, 2024
@janober
Copy link
Member

janober commented Nov 20, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants