Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(HTTP Request Node): Continue using error #11733

Merged
merged 1 commit into from
Nov 20, 2024
Merged

fix(HTTP Request Node): Continue using error #11733

merged 1 commit into from
Nov 20, 2024

Conversation

michael-radency
Copy link
Contributor

Summary

continue on fail support if error occurred during request configuration

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-1846/http-request-node-continue-using-error-output-not-working

@michael-radency michael-radency added node/improvement New feature or request n8n team Authored by the n8n team node/issue Issue with a node labels Nov 14, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 61.35458% with 97 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...es-base/nodes/HttpRequest/V3/HttpRequestV3.node.ts 61.35% 83 Missing and 14 partials ⚠️

📢 Thoughts on this report? Let us know!

ShireenMissi
ShireenMissi approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@cypress Cypress
Copy link

cypress bot commented Nov 20, 2024

n8n    Run #8004

Run Properties:  status check passed Passed #8004  •  git commit f1bde593a7: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 michael-radency 🗃️ e2e/*
Project n8n
Branch Review node-1846-http-request-node-continue-using-error-output-not-working
Run status status check passed Passed #8004
Run duration 04m 34s
Commit git commit f1bde593a7: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 michael-radency 🗃️ e2e/*
Committer Michael Kret
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 470
View all changes introduced in this branch ↗︎

@github-actions GitHub Actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@ShireenMissi ShireenMissi merged commit d1bae1a into master Nov 20, 2024
35 checks passed
@ShireenMissi ShireenMissi deleted the node-1846-http-request-node-continue-using-error-output-not-working branch November 20, 2024 10:48
@github-actions github-actions bot mentioned this pull request Nov 20, 2024
Merged
@janober
Copy link
Member

janober commented Nov 20, 2024

Got released with [email protected]

riascho pushed a commit that referenced this pull request Jan 14, 2025
@michael-radency @riascho
fix(HTTP Request Node): Continue using error (#11733)
963f8b2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShireenMissi ShireenMissi ShireenMissi approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team node/improvement New feature or request node/issue Issue with a node Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michael-radency @janober @ShireenMissi