fix(core): Ensure task runner server closes websocket connection correctly #11633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ectly The task runner server was erroring out when attempting to close the websocket connection with `100` which is not a [valid error code](https://github.com/Luka967/websocket-close-codes). https://linear.app/n8n/issue/PAY-2189
n8n-assistant
bot
added
core
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
tomi
previously approved these changes
Nov 8, 2024
Comment on lines
+41
to
+42
| response.writeHead(200); | ||
| expect(ws.close).not.toHaveBeenCalled(); |
There was a problem hiding this comment.
nit: This could be it's own test case as the test case name implies we are testing only status code >200
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
pay-2189
|
| Run status |
|
| Run duration | 04m 24s |
| Commit |
|
| Committer | Iván Ovejero |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
466
|
| View all changes introduced in this branch ↗︎ | |
|
✅ All Cypress E2E specs passed |
|
✅ All Cypress E2E specs passed |
|
Got released with |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The task runner server was erroring out when attempting to close the websocket connection with
100which is not a valid error code.https://linear.app/n8n/issue/PAY-2189