fix: Credentials save button is hidden unless you make changes to the #11492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShireenMissi
changed the title
n8n-assistant
bot
added
n8n team
ShireenMissi
force-pushed
the
node-1945-credentials-save-button-is-hidden-unless-you-make-changes-to-the
branch
from
0c95df1 to
7a7b3cb
Compare
ShireenMissi
force-pushed
the
node-1945-credentials-save-button-is-hidden-unless-you-make-changes-to-the
branch
from
7a7b3cb to
f527929
Compare
ShireenMissi
changed the title
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
elsmr
previously approved these changes
Nov 8, 2024
|
|
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
node-1945-credentials-save-button-is-hidden-unless-you-make-changes-to-the
|
| Run status |
|
| Run duration | 04m 27s |
| Commit |
|
| Committer | Shireen Missi |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
460
|
| View all changes introduced in this branch ↗︎ | |
elsmr
approved these changes
Nov 11, 2024
|
✅ All Cypress E2E specs passed |
ShireenMissi
deleted the
node-1945-credentials-save-button-is-hidden-unless-you-make-changes-to-the
branch
Merged
|
Got released with |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The save button on credentials doesn't show up unless changes made to the fields or name, this PR fixes the issue by always showing the button for new credentials
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-1945/credentials-save-button-is-hidden-unless-you-make-changes-to-the
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)