Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(editor): Auto focus first fields on SignIn, SignUp and ForgotMyPassword views #11445

Merged
merged 6 commits into from
Nov 1, 2024
Merged

fix(editor): Auto focus first fields on SignIn, SignUp and ForgotMyPassword views #11445

merged 6 commits into from
Nov 1, 2024
+389 −0

Conversation

cstuncsik
Copy link
Contributor

@cstuncsik cstuncsik commented Oct 29, 2024 •
edited
Loading

Summary

Improve UX for SignIn, SignUp, and ForgotMyPassword by focusing on the first input

Related Linear tickets, Github issues, and Community forum posts

PAY-2168

Review / Merge checklist

  • PR title and summary are descriptive
  • Tests included.

netroy
netroy reviewed Oct 29, 2024
View reviewed changes
Copy link
Member

@netroy netroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we are at it, can we also add focusInitially on

  1. firstName field in SignupView, and
  2. email field in ForgotMyPasswordView

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Oct 29, 2024
@cstuncsik cstuncsik changed the title fix(editor): Auto focus email field on sign-in view fix(editor): Auto focus first fields on SignIn, SignUp and ForgotMyPassword views Oct 29, 2024
@cstuncsik cstuncsik marked this pull request as ready for review November 1, 2024 10:45
netroy
netroy approved these changes Nov 1, 2024
View reviewed changes
Copy link
Member

@netroy netroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏽

@cypress Cypress
Copy link

cypress bot commented Nov 1, 2024

n8n    Run #7644

Run Properties:  status check passed Passed #7644  •  git commit dc14556e4e: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 cstuncsik 🗃️ e2e/*
Project n8n
Branch Review pay-2168-auto-focus-email-field-on-sign-in-page
Run status status check passed Passed #7644
Run duration 04m 24s
Commit git commit dc14556e4e: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 cstuncsik 🗃️ e2e/*
Committer Csaba Tuncsik
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 460
View all changes introduced in this branch ↗︎

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2024

✅ All Cypress E2E specs passed

@cstuncsik cstuncsik merged commit 5b5bd72 into master Nov 1, 2024
36 checks passed
@cstuncsik cstuncsik deleted the pay-2168-auto-focus-email-field-on-sign-in-page branch November 1, 2024 12:59
This was referenced Nov 6, 2024
Merged
Merged
@janober
Copy link
Member

janober commented Nov 6, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@netroy netroy netroy approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cstuncsik @janober @netroy